Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce metrics for serde #666

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: introduce metrics for serde #666

merged 1 commit into from
Aug 21, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Aug 21, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Maybe add a switch later.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added the feature New feature or request label Aug 21, 2024
@MrCroxx MrCroxx added this to the v0.11 milestone Aug 21, 2024
@MrCroxx MrCroxx self-assigned this Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Files Patch % Lines
foyer-storage/src/large/scanner.rs 66.66% 1 Missing ⚠️
Files Coverage Δ
foyer-common/src/metrics.rs 97.02% <100.00%> (+0.12%) ⬆️
foyer-storage/src/large/generic.rs 89.13% <100.00%> (+0.31%) ⬆️
foyer-storage/src/large/reclaimer.rs 86.08% <100.00%> (+0.24%) ⬆️
foyer-storage/src/large/recover.rs 90.84% <100.00%> (+0.13%) ⬆️
foyer-storage/src/serde.rs 100.00% <ø> (ø)
foyer-storage/src/store.rs 74.65% <100.00%> (+0.43%) ⬆️
foyer-storage/src/test_utils.rs 88.67% <100.00%> (+0.67%) ⬆️
foyer-storage/src/large/scanner.rs 68.65% <66.66%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

@MrCroxx MrCroxx merged commit 0e96638 into main Aug 21, 2024
15 checks passed
@MrCroxx MrCroxx deleted the xx/serde-metrics branch August 21, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant