Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore Cargo.lock #41

Closed
wants to merge 7 commits into from
Closed

chore: ignore Cargo.lock #41

wants to merge 7 commits into from

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jul 3, 2023

Signed-off-by: MrCroxx [email protected]

@MrCroxx MrCroxx added the chore label Jul 3, 2023
@MrCroxx MrCroxx self-assigned this Jul 3, 2023
Signed-off-by: MrCroxx <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #41 (6837b85) into main (691054a) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 6837b85 differs from pull request most recent head ce6ecef. Consider uploading reports for the commit ce6ecef to get more accurate results

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   41.10%   41.26%   +0.16%     
==========================================
  Files          33       30       -3     
  Lines        3484     3458      -26     
==========================================
- Hits         1432     1427       -5     
+ Misses       2052     2031      -21     

see 5 files with indirect coverage changes

MrCroxx added 3 commits July 3, 2023 17:09
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Jul 3, 2023

CI with address saniziter seems faced dead lock. But I didn't reappare it in either my local env or EC2 with poor EBS performance. I'm looking into the causes.

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Jul 3, 2023

Deadlock appeared with 1 worker thread. Some async task might not be awaked properly.

@MrCroxx
Copy link
Collaborator Author

MrCroxx commented Jul 4, 2023

Too many conflicts, will rewrite in another PR.

@MrCroxx MrCroxx closed this Jul 4, 2023
@MrCroxx MrCroxx deleted the xx/ignore-lock branch July 4, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants