-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: performance regression on RisingWave with 0.11 #708
Comments
Seems the memory buffer overhead in foyer 0.11 caused heavier operator memory eviction in RW. |
Can you share the memory consumption metrics from the foyer side ? |
Actually, I don't think there is a metrics showing it. It is caused by a temporary buffer that was introduced in 0.11. I'm trying to remove it when there is no compression needs. |
Solved. The regression is caused by the misleading argument |
There is an obvious regression on nexmark Q7 and Q014 for RisingWave with foyer 0.11 rather than with foyer 0.10.
Based on the flamegraph, the regression comes from 3 stacks:
Which are:
and
and
Let's see why.
Full flamegraphs:
Grafana:
010: https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=cdtasocg64074c&var-namespace=xx-foyer-010-1&var-instance=benchmark-risingwave&var-pod=All&var-component=All&var-table=All&from=1726042331594&to=1726086587137
011: https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=cdtasocg64074c&var-namespace=xx-foyer-011-1&var-instance=benchmark-risingwave&var-pod=All&var-component=All&var-table=All&from=1726041953341&to=1726086965390
The text was updated successfully, but these errors were encountered: