feat(forge): optimize compilation through preprocessing and caching (#10010)

* feat(forge): optimize compilation through preprocessing and caching

* Add various test scenarios

* Changes after review: rename cache_tests, add build option

* Update solar and compilers revs

* Update refs, add test with constructor args without name

* Bump compilers rev

* add test for named args, bump solar and compilers

* feat(forge): add vm.deployCode cheats with msg.value and salt

* Bump compilers, ctor test  with value and salt, ignore win panic

* Bump compilers with fix for win panic

* Bump compilers

* Update crates/common/src/compile.rs

Co-authored-by: DaniPopes <[email protected]>

* bump

* bump solar

* bump solar 2

* bump compilers

* ename config dynamic_test_linking, bump compilers

* Dynamic test linking default enabled

* More test fixes

* chore: move preprocessor from compilers

* bump

* Ensure no cached artifacts in projects

* Disable by default

* Handle constructor expectRevert

* Collect deps from call args too

* Bump solar, use upstream fix for call args deps

* Bump solar, compilers and block explorers

---------

Co-authored-by: DaniPopes <[email protected]>

Author: grandizzy

Cargo.lock

@@ -188,11 +188,12 @@ foundry-wallets = { path = "crates/wallets" }
 foundry-linking = { path = "crates/linking" }
 
 # solc & compilation utilities
-foundry-block-explorers = { version = "0.11.0", default-features = false }
-foundry-compilers = { version = "0.13.5", default-features = false }
+foundry-block-explorers = { version = "0.13.0", default-features = false }
+foundry-compilers = { version = "0.14.0", default-features = false }
 foundry-fork-db = "0.12"
 solang-parser = "=0.3.3"
-solar-parse = { version = "=0.1.1", default-features = false }
+solar-parse = { version = "=0.1.2", default-features = false }
+solar-sema = { version = "=0.1.2", default-features = false }
 
 ## revm
 revm = { version = "19.4.0", default-features = false }
@@ -309,6 +310,7 @@ tracing-subscriber = "0.3"
 url = "2"
 vergen = { version = "8", default-features = false }
 yansi = { version = "1.0", features = ["detect-tty", "detect-env"] }
+path-slash = "0.2"
 
 [patch.crates-io]
 ## alloy-core

Cargo.toml

@@ -371,19 +371,22 @@ fn deploy_code(
         revm::primitives::CreateScheme::Create
     };
 
-    let address = executor
-        .exec_create(
-            CreateInputs {
-                caller: ccx.caller,
-                scheme,
-                value: value.unwrap_or(U256::ZERO),
-                init_code: bytecode.into(),
-                gas_limit: ccx.gas_limit,
-            },
-            ccx,
-        )?
-        .address
-        .ok_or_else(|| fmt_err!("contract creation failed"))?;
+    let outcome = executor.exec_create(
+        CreateInputs {
+            caller: ccx.caller,
+            scheme,
+            value: value.unwrap_or(U256::ZERO),
+            init_code: bytecode.into(),
+            gas_limit: ccx.gas_limit,
+        },
+        ccx,
+    )?;
+
+    if !outcome.result.result.is_ok() {
+        return Err(crate::Error::from(outcome.result.output))
+    }
+
+    let address = outcome.address.ok_or_else(|| fmt_err!("contract creation failed"))?;
 
     Ok(address.abi_encode())
 }

crates/cheatcodes/src/fs.rs

@@ -34,6 +34,11 @@ pub struct BuildOpts {
     #[serde(skip)]
     pub no_cache: bool,
 
+    /// Enable dynamic test linking.
+    #[arg(long, conflicts_with = "no_cache")]
+    #[serde(skip)]
+    pub dynamic_test_linking: bool,
+
     /// Set pre-linked libraries.
     #[arg(long, help_heading = "Linker options", env = "DAPP_LIBRARIES")]
     #[serde(skip_serializing_if = "Vec::is_empty")]
@@ -245,6 +250,10 @@ impl Provider for BuildOpts {
             dict.insert("cache".to_string(), false.into());
         }
 
+        if self.dynamic_test_linking {
+            dict.insert("dynamic_test_linking".to_string(), true.into());
+        }
+
         if self.build_info {
             dict.insert("build_info".to_string(), self.build_info.into());
         }

crates/cli/src/opts/build/core.rs

@@ -45,6 +45,9 @@ alloy-transport.workspace = true
 alloy-consensus = { workspace = true, features = ["k256"] }
 alloy-network.workspace = true
 
+solar-parse.workspace = true
+solar-sema.workspace = true
+
 tower.workspace = true
 
 async-trait.workspace = true
@@ -64,6 +67,7 @@ tracing.workspace = true
 url.workspace = true
 walkdir.workspace = true
 yansi.workspace = true
+path-slash.workspace = true
 
 anstream.workspace = true
 anstyle.workspace = true