chore(forge-lint): clickable links + housekeeping (#10847)

Author: 0xrusowsky

Cargo.lock

@@ -1,6 +1,5 @@
 use super::AsmKeccak256;
 use crate::{
-    declare_forge_lint,
     linter::EarlyLintPass,
     sol::{Severity, SolLint},
 };

crates/lint/src/sol/gas/keccak.rs

@@ -1,7 +1,4 @@
-use crate::{
-    register_lints,
-    sol::{EarlyLintPass, SolLint},
-};
+use crate::sol::{EarlyLintPass, SolLint};
 
 mod keccak;
 use keccak::ASM_KECCAK256;

crates/lint/src/sol/gas/mod.rs

@@ -1,6 +1,5 @@
 use super::IncorrectShift;
 use crate::{
-    declare_forge_lint,
     linter::{EarlyLintPass, LintContext},
     sol::{Severity, SolLint},
 };

crates/lint/src/sol/high/incorrect_shift.rs

@@ -1,7 +1,4 @@
-use crate::{
-    register_lints,
-    sol::{EarlyLintPass, SolLint},
-};
+use crate::sol::{EarlyLintPass, SolLint};
 
 mod incorrect_shift;
 use incorrect_shift::INCORRECT_SHIFT;

crates/lint/src/sol/high/mod.rs

@@ -1,6 +1,5 @@
 use super::{MixedCaseFunction, MixedCaseVariable};
 use crate::{
-    declare_forge_lint,
     linter::{EarlyLintPass, LintContext},
     sol::{Severity, SolLint},
 };

crates/lint/src/sol/info/mixed_case.rs

@@ -1,7 +1,4 @@
-use crate::{
-    register_lints,
-    sol::{EarlyLintPass, SolLint},
-};
+use crate::sol::{EarlyLintPass, SolLint};
 
 mod mixed_case;
 use mixed_case::{MIXED_CASE_FUNCTION, MIXED_CASE_VARIABLE};

crates/lint/src/sol/info/mod.rs

@@ -1,6 +1,5 @@
 use super::PascalCaseStruct;
 use crate::{
-    declare_forge_lint,
     linter::{EarlyLintPass, LintContext},
     sol::{Severity, SolLint},
 };

crates/lint/src/sol/info/pascal_case.rs

@@ -1,6 +1,5 @@
 use super::ScreamingSnakeCase;
 use crate::{
-    declare_forge_lint,
     linter::{EarlyLintPass, LintContext},
     sol::{Severity, SolLint},
 };

crates/lint/src/sol/info/screaming_snake_case.rs

@@ -1,3 +1,10 @@
+#[macro_export]
+macro_rules! link {
+    ($url:expr) => {
+        concat!("\x1b]8;;", $url, "\x1b\\", $url, "\x1b]8;;\x1b\\")
+    };
+}
+
 /// Macro for defining lints and relevant metadata for the Solidity linter.
 ///
 /// # Parameters
@@ -20,7 +27,7 @@ macro_rules! declare_forge_lint {
             id: $str_id,
             severity: $severity,
             description: $desc,
-            help: concat!("https://book.getfoundry.sh/reference/forge/forge-lint#", $str_id),
+            help: link!(concat!("https://book.getfoundry.sh/reference/forge/forge-lint#", $str_id)),
         };
     };