Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependencies section in Soldeer #1252

Closed
Braqzen opened this issue Aug 5, 2024 · 0 comments · Fixed by #1253
Closed

Missing dependencies section in Soldeer #1252

Braqzen opened this issue Aug 5, 2024 · 0 comments · Fixed by #1253

Comments

@Braqzen
Copy link
Contributor

Braqzen commented Aug 5, 2024

Note: I've only read the docs and noticed a discrepancy. I have not verified it. If it's invalid then feel free to close.

In soldeer.md there is a heading Add a Dependency Stored in the Central Repository which contains a toml block.
In the block it states that the following line must be added

libs = ["dependencies"] # <= This is important to be added

Scrolling down a little to Updating Dependencies there is a similar toml block and comment. The difference is that the line is missing but the comment is pointing at a different line.

gas_reports = ["*"] # <= This is important to be added

It appears that this may have been a mistake and that line was removed while the comment remained.

Solution: Add the line back in and move the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant