Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp serve task blocks watch; browser.reload blocks watch #11443

Closed
4 tasks done
aorinevo opened this issue Aug 12, 2018 · 1 comment · Fixed by #11444
Closed
4 tasks done

Gulp serve task blocks watch; browser.reload blocks watch #11443

aorinevo opened this issue Aug 12, 2018 · 1 comment · Fixed by #11444

Comments

@aorinevo
Copy link
Contributor

What should happen?

When running npm start the project should build, the server should start, and browser should automatically reload on changes.

What happens instead?

Project gets built, server starts, but browser does not reload on changes.

Possible Solution

Use the done callback in watch task and wrap browser.reload in a callback that executes the gulp done callback after reload.

Test Case and/or Steps to Reproduce

Test Case:

How to reproduce:

  1. Run npm start
  2. Edit a file that's targeted by one of the watch globs (i.e. docs/pages/welcome.md
  3. Watch does not pick up the changes and browser does not reload

Context

Slows development.

Your Environment

  • Foundation version(s) used: 6.4.3 (develop branch)
  • Browser(s) name and version(s): Chrome, Safari, Firefox
  • Operating System and version (desktop or mobile): Mac High Sierra v10.13.6

Checklist (all required):

  • I have read and follow the CONTRIBUTING.md document.
  • There are no other issues similar to this one.
  • The issue title is descriptive.
  • The template is correctly filled.
@ncoden
Copy link
Contributor

ncoden commented Aug 12, 2018

Hi @aorinevo, thank you for your issue and pull request. I will take a look at it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants