Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xy-grid-layout mixin missing a parameter in Sass Reference documentation #11297

Closed
jeremylind opened this issue May 24, 2018 · 1 comment
Closed

Comments

@jeremylind
Copy link
Contributor

Description

The xy-grid-layout mixin documentation at https://foundation.zurb.com/sites/docs/xy-grid.html#xy-grid-layout is missing the $breakpoint parameter. The default value for $breakpoint is $-zf-zero-breakpoint, which is equal to small (I think this is also an issue, but it looks like it's addressed here: #11145). However, the user can define the $breakpoint parameter when including xy-grid-layout. In fact, it's necessary in order to get responsive gutters (until the pull request I linked to is released anyway).

Possible Solution

Add the $breakpoint parameter to the parameter list for xy-grid-layout in the Sass Reference section of the XY Grid documentation page.

Checklist (all required):

  • [ X] I have read and follow the CONTRIBUTING.md document.
  • [ X] There are no other issues similar to this one.
  • [ X] The issue title is descriptive.
  • [ X] The template is correctly filled.
@ncoden
Copy link
Contributor

ncoden commented May 24, 2018

Hi @jeremylind,

You are right, this was fixed at #11145. For the missing parameter in documentation, I think the documentation server is out-of-date. The Sass reference is automatically generated. It should be resolved at the next release.

@ncoden ncoden closed this as completed May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants