Block Grid not aligning correctly with grid-margin-x in 6.4.3

[lrobson555]

How to reproduce this bug:

1. Create a block grid that only uses small-up-3, no medium or large classes, with grid-margin-x

What should happen:

Three columns should be displayed in a row with margins between.

What happened instead:

Only two columns are displayed in a row.
Looks like when calculating the width of each column using the percentage minus the margin, it's only taking into account a 20px margin instead of 30px.

Browser(s) and Device(s) tested on:

Chrome v 65.0.3325.181, macOS Sierra 10.12.6

Foundation Version(s) you are using:

Broken on 6.4.3, seems to work fine in 6.4.0.

Test case link:

Broken in first, works in second:

• CodePen with Foundation 6.4.3 and XY Grid
• CodePen with Foundation 6.4.0 and XY Grid

[DanielRuf]

The bug was introduced between 6.4.1 and 6.4.2-rc1.

Will do some bisecting.

[DanielRuf]

$ git bisect bad
8a0ae1958a58a084e6fe0049482df483ce7a8b3c is the first bad commit
commit 8a0ae1958a58a084e6fe0049482df483ce7a8b3c
Author: Kevin Ball <[email protected]>
Date:   Fri Jul 21 08:37:21 2017 -0700

    Merge pull request #10435 from zurb/xy-grid-layout-fix

    Add missing arguement for xy-grid-layout mixin

:040000 040000 7a37fc20973f7df6a5e3f83c089016c355353544 26fb8348cbcedb0ef5d783bb3bc5913fc2eef8d0 M      scss

Daniel@Daniel-MSI MINGW64 ~/GITHUB/foundation-sites ((8a0ae1958...)|BISECTING)
$ git show 8a0ae1958a58a084e6fe0049482df483ce7a8b3c
commit 8a0ae1958a58a084e6fe0049482df483ce7a8b3c (HEAD, refs/bisect/bad)
Author: Kevin Ball <[email protected]>
Date:   Fri Jul 21 08:37:21 2017 -0700

    Merge pull request #10435 from zurb/xy-grid-layout-fix

    Add missing arguement for xy-grid-layout mixin

diff --git a/scss/xy-grid/_layout.scss b/scss/xy-grid/_layout.scss
index bd8c14284..3b7650e32 100644
--- a/scss/xy-grid/_layout.scss
+++ b/scss/xy-grid/_layout.scss
@@ -28,6 +28,6 @@
   $size: percentage(1/$n);

   & > #{$selector} {
-    @include xy-cell($size, $gutter-output, $gutter-type: $gutter-type, $gutter-position: $gutter-position, $vertical: $vertical);
+    @include xy-cell($size, $gutter-output, $gutters, $gutter-type, $gutter-position, $breakpoint, $vertical);
   }
 }

8a0ae19

[DanielRuf]

The mixin has following arguments

@mixin xy-cell(
  $size: full,
  $gutter-output: true,
  $gutters: $grid-margin-gutters,
  $gutter-type: margin,
  $gutter-position: right left,
  $breakpoint: null,
  $vertical: false
) {

[DanielRuf]

Please test the linked PR.