Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flex Grid] .row and .column classes aren't receiving default styles #10425

Closed
designerdean opened this issue Jul 17, 2017 · 9 comments
Closed
Assignees

Comments

@designerdean
Copy link

How to reproduce this bug:

Simply create a div.row with a nested div.column. Notice that there is no longer a max-width set by default.

What should happen:

The div.row should have the max-width equal to whatever is defined as $global-width.

What happened instead:

Neither the div.row nor div.column are receiving any styles like they were in v6.3.

Browser(s) and Device(s) tested on:

Chrome on Macbook Pro.

Foundation Version(s) you are using: 6.4.1

Test case link:

@rafibomb
Copy link
Member

The XY Gris uses different syntax. Since you are looking to use the flex-grid, you'll want to change this in app.scss

@include foundation-flex-grid;
//
// @include foundation-xy-grid-classes;

@designerdean
Copy link
Author

Well this is what I have had in app.scss:

screen shot 2017-07-18 at 10 03 43 am

If I add @include foundation-flex-grid; after @include foundation-everything($flex: true); then it works. But it seems like that defeats the purpose of ($flex: true)...doesn't it?

@brettsmason
Copy link
Contributor

@designerdean you can set $xy-grid: false; in your settings file and that will use the flex grid rather than the XY grid when using the everything mixin. Probably needs better documentation on that.

@designerdean
Copy link
Author

Ohhhhh...so if I swet $xy-grid: false; in my settings file, I assume my app.scss file should look like this?

screen shot 2017-07-18 at 10 36 50 am

@brettsmason
Copy link
Contributor

Yep exactly.

@designerdean
Copy link
Author

Perfect. Thank you so much for the help!

@brettsmason
Copy link
Contributor

Great glad its working now. I think we need some docs changes to make this clearer so going to leave this open for now.

@idevtech
Copy link

idevtech commented Sep 27, 2017

I had the same problem and the fix worked. Documentation definitely needs updating to indicate if

@include foundation-everything(true)

which is what would be present to turn Flex-Grid on prior to 6.4 will be use the new XY-Grid instead and to use Flex-Grid the following needs to be added to the settings.scss file.

$xy-grid: false;

@DanielRuf
Copy link
Contributor

Closing as #10962 is merged so the docs are a bit more clear about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants