fix: Let event fields be nullable (#7251)

Author: iamareebjamal

app/api/events.py

@@ -72,7 +72,7 @@ def validate_event(user, data):
 
     if not data.get('name', None) and data.get('state', None) == 'published':
         raise ConflictError(
-            {'pointer': '/data/attributes/location-name'},
+            {'pointer': '/data/attributes/name'},
             "Event Name is required to publish the event",
         )
 

app/api/schema/events.py

@@ -10,10 +10,8 @@
 from app.api.helpers.utilities import dasherize
 from app.api.schema.base import SoftDeletionSchema
 from app.models.event import Event
-from utils.common import use_defaults
 
 
-@use_defaults()
 class EventSchemaPublic(SoftDeletionSchema):
     class Meta:
         type_ = 'event'

tests/all/integration/api/event/__init__.py

@@ -0,0 +1,67 @@
+import json
+
+from tests.factories.event import EventFactoryBasic
+
+
+def get_event(db):
+    event = EventFactoryBasic(location_name='Amsterdam')
+    db.session.commit()
+
+    return event
+
+
+def test_edit_event_default_field(db, client, admin_jwt):
+    # Should let the previous value remain unchanged if field is not present in data
+    event = get_event(db)
+
+    data = json.dumps(
+        {
+            'data': {
+                'type': 'event',
+                'id': str(event.id),
+                'attributes': {'timezone': 'Europe/Berlin'},
+            }
+        }
+    )
+
+    response = client.patch(
+        f'/v1/events/{event.id}',
+        content_type='application/vnd.api+json',
+        headers=admin_jwt,
+        data=data,
+    )
+
+    db.session.refresh(event)
+
+    assert response.status_code == 200
+    assert event.location_name == 'Amsterdam'
+    assert event.timezone == 'Europe/Berlin'
+
+
+def test_edit_event_null_field(db, client, admin_jwt):
+    # Should let the previous value be nulled if field is null in data
+    event = get_event(db)
+
+    assert event.location_name == 'Amsterdam'
+
+    data = json.dumps(
+        {
+            'data': {
+                'type': 'event',
+                'id': str(event.id),
+                'attributes': {'location-name': None},
+            }
+        }
+    )
+
+    response = client.patch(
+        f'/v1/events/{event.id}',
+        content_type='application/vnd.api+json',
+        headers=admin_jwt,
+        data=data,
+    )
+
+    db.session.refresh(event)
+
+    assert response.status_code == 200
+    assert event.location_name is None