From 8245c83ea372bbe5e2226ead2f5e89afaee0510d Mon Sep 17 00:00:00 2001
From: Parth910 <prp4203@gmail.com>
Date: Sun, 11 Aug 2019 21:12:41 +0530
Subject: [PATCH 1/4] user profile update:phone number compulsory field remove

---
 app/components/forms/user-profile-form.js         | 15 ---------------
 .../components/forms/user-profile-form.hbs        |  2 +-
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/app/components/forms/user-profile-form.js b/app/components/forms/user-profile-form.js
index 63376f54614..5ba5c0503d6 100644
--- a/app/components/forms/user-profile-form.js
+++ b/app/components/forms/user-profile-form.js
@@ -1,6 +1,5 @@
 import Component from '@ember/component';
 import FormMixin from 'open-event-frontend/mixins/form';
-import { validPhoneNumber } from 'open-event-frontend/utils/validators';
 
 export default Component.extend(FormMixin, {
 
@@ -41,20 +40,6 @@ export default Component.extend(FormMixin, {
               prompt : this.l10n.t('Please enter a valid email ID')
             }
           ]
-        },
-        phone: {
-          identifier : 'phone',
-          rules      : [
-            {
-              type   : 'empty',
-              prompt : this.l10n.t('Please enter a phone number.')
-            },
-            {
-              type   : 'regExp',
-              value  : validPhoneNumber,
-              prompt : this.l10n.t('Please enter a valid phone number.')
-            }
-          ]
         }
       }
     };
diff --git a/app/templates/components/forms/user-profile-form.hbs b/app/templates/components/forms/user-profile-form.hbs
index 8a71ddd4859..8fabaac8983 100644
--- a/app/templates/components/forms/user-profile-form.hbs
+++ b/app/templates/components/forms/user-profile-form.hbs
@@ -41,7 +41,7 @@
       </div>
       <div class="field">
         <label class="details">{{t 'Phone'}}</label>
-        {{input type='text' name='phone' value=user.contact}}
+        {{input type='number' name='phone' value=user.contact}}
       </div>
       <button type="submit" class="ui teal submit button update-changes">
         {{t 'Update Changes'}}

From 87e18fea664a23644ee0ebcea436c25ec4d9ac19 Mon Sep 17 00:00:00 2001
From: Parth Patel <31615065+Parth910@users.noreply.github.com>
Date: Sun, 11 Aug 2019 23:33:34 +0530
Subject: [PATCH 2/4] fix: phone field made optional

---
 app/components/forms/user-profile-form.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/app/components/forms/user-profile-form.js b/app/components/forms/user-profile-form.js
index 5ba5c0503d6..264df1cd5f4 100644
--- a/app/components/forms/user-profile-form.js
+++ b/app/components/forms/user-profile-form.js
@@ -1,5 +1,6 @@
 import Component from '@ember/component';
 import FormMixin from 'open-event-frontend/mixins/form';
+import { validPhoneNumber } from 'open-event-frontend/utils/validators';
 
 export default Component.extend(FormMixin, {
 
@@ -40,6 +41,21 @@ export default Component.extend(FormMixin, {
               prompt : this.l10n.t('Please enter a valid email ID')
             }
           ]
+        },
+        phone: {
+          identifier : 'phone',
+          optional   : true,
+          rules      : [
+            {
+              type   : 'empty',
+              prompt : this.l10n.t('Please enter a phone number')
+            },
+            {
+              type   : 'regExp',
+              value  : validPhoneNumber,
+              prompt : this.l10n.t('Please enter a valid phone number')
+            }
+          ]
         }
       }
     };

From 7b322079a65c1bb46a3e2f8a5b8a7c6c984e4f5b Mon Sep 17 00:00:00 2001
From: Parth Patel <31615065+Parth910@users.noreply.github.com>
Date: Sun, 11 Aug 2019 23:33:57 +0530
Subject: [PATCH 3/4] Update user-profile-form.hbs

---
 app/templates/components/forms/user-profile-form.hbs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/templates/components/forms/user-profile-form.hbs b/app/templates/components/forms/user-profile-form.hbs
index 8fabaac8983..8a71ddd4859 100644
--- a/app/templates/components/forms/user-profile-form.hbs
+++ b/app/templates/components/forms/user-profile-form.hbs
@@ -41,7 +41,7 @@
       </div>
       <div class="field">
         <label class="details">{{t 'Phone'}}</label>
-        {{input type='number' name='phone' value=user.contact}}
+        {{input type='text' name='phone' value=user.contact}}
       </div>
       <button type="submit" class="ui teal submit button update-changes">
         {{t 'Update Changes'}}

From 51f5f97676bf6bf9cf8bd704ba67051436de635f Mon Sep 17 00:00:00 2001
From: Parth910 <prp4203@gmail.com>
Date: Mon, 12 Aug 2019 15:27:14 +0530
Subject: [PATCH 4/4] add optional type and remove emtpy type

---
 app/components/forms/user-profile-form.js            | 12 ++++++++++++
 app/templates/components/forms/user-profile-form.hbs |  2 +-
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/app/components/forms/user-profile-form.js b/app/components/forms/user-profile-form.js
index 5ba5c0503d6..46dd57e3b00 100644
--- a/app/components/forms/user-profile-form.js
+++ b/app/components/forms/user-profile-form.js
@@ -1,5 +1,6 @@
 import Component from '@ember/component';
 import FormMixin from 'open-event-frontend/mixins/form';
+import { validPhoneNumber } from 'open-event-frontend/utils/validators';
 
 export default Component.extend(FormMixin, {
 
@@ -40,6 +41,17 @@ export default Component.extend(FormMixin, {
               prompt : this.l10n.t('Please enter a valid email ID')
             }
           ]
+        },
+        phone: {
+          identifier : 'phone',
+          optional   : true,
+          rules      : [
+            {
+              type   : 'regExp',
+              value  : validPhoneNumber,
+              prompt : this.l10n.t('Please enter a valid phone number')
+            }
+          ]
         }
       }
     };
diff --git a/app/templates/components/forms/user-profile-form.hbs b/app/templates/components/forms/user-profile-form.hbs
index 8fabaac8983..8a71ddd4859 100644
--- a/app/templates/components/forms/user-profile-form.hbs
+++ b/app/templates/components/forms/user-profile-form.hbs
@@ -41,7 +41,7 @@
       </div>
       <div class="field">
         <label class="details">{{t 'Phone'}}</label>
-        {{input type='number' name='phone' value=user.contact}}
+        {{input type='text' name='phone' value=user.contact}}
       </div>
       <button type="submit" class="ui teal submit button update-changes">
         {{t 'Update Changes'}}