using default USD currency in admin/sales location #2403
Conversation
| <td>{{entry.locationName}}</td> | ||
| <td class="right aligned">{{entry.sales.completed.ticket_count}}</td> | ||
| <td class="right aligned">{{currency-symbol entry.paymentCurrency}} {{number-format entry.sales.completed.sales_total}}</td> | ||
| <td class="right aligned">US$ {{number-format entry.sales.completed.sales_total}}</td> |
There was a problem hiding this comment.
This is not the valid fix @uds5501 as the line {{currency-symbol entry.paymentCurrency}} was written to correctly render the currency parser and by setting it to default 'US $' , You are not making valid fix.
There was a problem hiding this comment.
@kushthedude It actually is a valid fix . Did you read the pertaining argument in the issue itself?
The location part of the admin/sales is not yet ready for event based currency parsing.
At a location ABC suppose there are 3 events. 2 of them use USD and one of them uses CAD. What would you show then, USD or CAD? :)
There was a problem hiding this comment.
Thats what i was saying , How did you came to know location part cant render event bases currency parsing?
There was a problem hiding this comment.
How can i make them ready for currency parsing?
@uds5501
There was a problem hiding this comment.
@kushthedude Regarding that, I have proposed #2253 to be worked during GSoC period. I will standardise the amount of other currency into USD and that should do it!
|
@CosmicCoder96 shouldnt this supposed to be in #2376 |
3 participants
Checklist
developmentbranch.Short description of what this resolves:
We can't use paymentCurrency of an event based on location because on a location, different events with different currencies maybe present and they can't be displayed under a single tab using a single payment Currency unless standardised.
Changes proposed in this pull request:
Fixes #2402