Add a label in front of Sessions in the Speaker table #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavk96
suggested changes
Jan 24, 2019
Contributor
abhinavk96
left a comment
abhinavk96
left a comment
There was a problem hiding this comment.
Can you also link the sessions to their edit link?
abhinavk96
suggested changes
Jan 24, 2019
| {{#if (not eq session.deletedAt)}} | ||
| <div class="item"> | ||
| {{session.title}} | ||
| {{#if (eq session.state "accepted")}} |
Contributor
There was a problem hiding this comment.
This code can be optimized a lot, return the color as a computed property based on the status of the session.
ritikamotwani
force-pushed
the
development
branch
from
d57385e to
7d4a79f
Compare
abhinavk96
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developmentbranch.Short description of what this resolves:
Adds a label with the session name in the speakers table.
Changes proposed in this pull request:
Fixes #1942