Skip to content

Fix import Event #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhinavk96 merged 4 commits into from
Mar 6, 2019
Merged

Fix import Event #1945

abhinavk96 merged 4 commits into from
Mar 6, 2019

Conversation

@YogeshSharma0201
Copy link
Contributor

@YogeshSharma0201 YogeshSharma0201 commented Jan 22, 2019

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

This PR is subpart of PR #1788, for easier testing and review.
Backend Changes PR fossasia/open-event-server/pull/5531

abhinavk96
abhinavk96 suggested changes Jan 24, 2019
View reviewed changes
@uds5501 uds5501 mentioned this pull request Jan 27, 2019
Closed
6 tasks
niranjan94
niranjan94 suggested changes Jan 28, 2019
View reviewed changes
@YogeshSharma0201 YogeshSharma0201 force-pushed the import_event branch 2 times, most recently from 985e942 to 1ae4d9a Compare January 29, 2019 07:10
niranjan94
niranjan94 suggested changes Jan 29, 2019
View reviewed changes
@abhinavk96 abhinavk96 requested a review from niranjan94 February 2, 2019 17:40
niranjan94
niranjan94 suggested changes Feb 3, 2019
View reviewed changes
abhinavk96
abhinavk96 reviewed Feb 9, 2019
View reviewed changes
Copy link
Contributor

@abhinavk96 abhinavk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshSharma0201 Update this PR please

niranjan94
niranjan94 suggested changes Feb 9, 2019
View reviewed changes
app/controllers/events/import.js
var endpoint = 'import/json';
var ext = file.name.split('.');
ext = ext[ext.length - 1].toLowerCase();
if (ext === 'xml') {
Copy link
Member

@niranjan94 niranjan94 Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about .zip, .xcal cases ? The upload input accepts those too

Copy link
Contributor Author

@YogeshSharma0201 YogeshSharma0201 Feb 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan94 actually only .zip files can be successfully imported, its endpoint is import/json. Other cases don't even have a valid endpoint, but eventyay had this code so i thought they can be implemented later on the server side. Should i only accept .zip then?

Copy link
Contributor

@abhinavk96 abhinavk96 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshSharma0201 add the .zip and .xcal cases, it's fine if server doesn't accept them for now.

abhinavk96
abhinavk96 suggested changes Mar 4, 2019
View reviewed changes
app/controllers/events/import.js
var endpoint = 'import/json';
var ext = file.name.split('.');
ext = ext[ext.length - 1].toLowerCase();
if (ext === 'xml') {
Copy link
Contributor

@abhinavk96 abhinavk96 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshSharma0201 add the .zip and .xcal cases, it's fine if server doesn't accept them for now.

@YogeshSharma0201
Copy link
Contributor Author

YogeshSharma0201 commented Mar 5, 2019

@CosmicCoder96 i have included .xcal case and .zip is already added, its api is import/json.

@abhinavk96 abhinavk96 merged commit 4b711e6 into fossasia:development Mar 6, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-frontend that referenced this pull request Apr 1, 2019
@YogeshSharma0201 @mrsaicharan1
Fix import Event (fossasia#1945)
cc883aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niranjan94 niranjan94 Awaiting requested review from niranjan94

1 more reviewer

@abhinavk96 abhinavk96 abhinavk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YogeshSharma0201 @niranjan94 @abhinavk96