Fix Event Imports #1788
Fix Event Imports #1788
Conversation
rajvaibhavdubey
left a comment
rajvaibhavdubey
left a comment
There was a problem hiding this comment.
Fix Conflicts, Your branch is out of date.
abhinavk96
left a comment
abhinavk96
left a comment
There was a problem hiding this comment.
Hi @YogeshSharma0201 Any updates on this?
YogeshSharma0201
force-pushed
the
fix_import_event
branch
from
03af32e to
9cd3ffc
Compare
|
@CosmicCoder96 i have removed jquery usage. |
| }, | ||
| async model() { | ||
|
|
||
| const data = await this.get('store').findAll('importJob'); |
There was a problem hiding this comment.
This is not a valid query. There is no importJob model, please try importing the event yourself, and request a review when it works.
There was a problem hiding this comment.
I have implemented the importJob model both in backend and fronted. Please check fossasia/open-event-server#5514.
There was a problem hiding this comment.
I have tested it locally, it works.
There was a problem hiding this comment.
@YogeshSharma0201 Oh okay will check on the server.
There was a problem hiding this comment.
@YogeshSharma0201 Okay, so excellent work on this PR. You actually combined two separate issues into this single PR.
- Issue A: One issue comprises of just getting an event to import successfully on the
/v1/events/import/jsonendpoint. - Issue B: And then next was listing the import jobs for which you have created a new model on the server.
We will be proceeding step by step. Please keep this PR and the PR on the server Open, I will add an appropriate label to this.
Next, please send a new PR in which only issue A gets fixed. Issue A won't require any changes on the server I believe. If you have any confusion regarding these instructions please ping me on gitter, thanks !
|
@CosmicCoder96 Issue A would also require changes on server side, see changes in file app/models/event.py and app/api/helpers/utilities.py in server side pr, these changes are required for successfully importing events. Should i still open a separate pr? |
|
@YogeshSharma0201 Yes, please still open a separate PR. Also, we can't have the mentioned changes in the utilities.py, it will break several other things, try to find a workaround to that. |
abhinavk96
left a comment
abhinavk96
left a comment
There was a problem hiding this comment.
@YogeshSharma0201 You can now proceed with this. Update it please, thanks.
YogeshSharma0201
force-pushed
the
fix_import_event
branch
from
3cd092f to
77c3d31
Compare
|
@YogeshSharma0201 Still on it ? |
|
@kushthedude this PR is complete and updated (no merge conflicts) |
|
@YogeshSharma0201 thats great , @CosmicCoder96 review please. |
6 participants
Checklist
developmentbranch.Short description of what this resolves:
Event Import is working now and previous import jobs are being displayed.
Only zip files can be used for importing as of now and other importing methods are not implemented on backend.
Changes proposed in this pull request:
Fixes #767
Backend Changes PR: fossasia/open-event-server#5514