Optimized donationsValidation property

Author: mrsaicharan1

app/components/public/ticket-list.js

@@ -49,19 +49,14 @@ export default Component.extend(FormMixin, {
   donationTickets: computed.filterBy('data', 'type', 'donation'),
 
   isDonationPriceValid: computed('[email protected]', '[email protected]', function() {
-    let returnValue = false;
-    this.donationTickets.forEach(donationTicket => {
+    for (const donationTicket of this.donationTickets) {
       if (donationTicket.orderQuantity > 0) {
-        if (donationTicket.price >= donationTicket.minPrice &&  donationTicket.price <= donationTicket.maxPrice) {
-          returnValue = true;
-        } else {
-          returnValue = false;
+        if (donationTicket.price < donationTicket.minPrice || donationTicket.price > donationTicket.maxPrice) {
+          return false;
         }
-      } else {
-        returnValue = true;
       }
-    });
-    return returnValue;
+    }
+    return true;
   }),
 
   total: computed('[email protected]', '[email protected]', '[email protected]', function() {
@@ -201,7 +196,7 @@ export default Component.extend(FormMixin, {
     }
   },
   donationTicketsValidation: computed('[email protected]', '[email protected]', '[email protected]', function() {
-    let validationRules = {};
+    const validationRules = {};
     for (let donationTicket of this.donationTickets) {
       validationRules[donationTicket.id] =  {
         identifier : donationTicket.id,
@@ -217,7 +212,7 @@ export default Component.extend(FormMixin, {
     return validationRules;
   }),
   getValidationRules() {
-    let validationRules = {
+    const validationRules = {
       inline : true,
       delay  : false,
       on     : 'blur',