clean up, DRY and tests

Author: abhinavk96

app/components/tables/base.js

@@ -1,5 +1,4 @@
 import Component from '@ember/component';
-import { action } from '@ember/object';
 
 export default class extends Component {
 

app/components/tables/default.js

@@ -18,12 +18,18 @@ export default class extends Component {
 
 
   didInsertElement() {
+    super.didInsertElement(...arguments);
     if (this.sorts && this.sorts[0] && this.sorts[0].valuePath === this.column.valuePath) {
-      this.set('sortBy', this.sorts[0].valuePath);
-      this.set('sortDir', this.sorts[0].isAscending ? 'ASC' : 'DSC');
+      this.setProperties({
+        sortBy  : this.sorts[0].valuePath,
+        sortDir : this.sorts[0].isAscending ? 'ASC' : 'DSC'
+      });
+
     } else {
-      this.set('sortBy', null);
-      this.set('sortDir', null);
+      this.setProperties({
+        sortBy  : null,
+        sortDir : null
+      });
     }
   }
 }

app/components/tables/events/list.js

@@ -3,9 +3,7 @@ import { computed, action, get } from '@ember/object';
 
 export default class extends Component {
 
-  totalCount = 100;
 
-  metaPagesCountProperty = 'page[size]';
   metaItemsCountProperty = 'count';
 
   @computed('currentPage', 'pageSize', 'totalContentLength')

app/components/tables/headers/sort.js

@@ -1,4 +1,5 @@
 import Component from '@ember/component';
 
-export default Component.extend({
-});
+export default class extends Component {
+
+}

app/components/tables/utilities/pagination.js

@@ -4,7 +4,7 @@ import { computed, action } from '@ember/object';
 export default class extends Controller {
   queryParams = ['page', 'per_page'];
   page = 1;
-  per_page = 2;
+  per_page = 10;
   search = null;
   sort_dir = null;
   sort_by = null;
@@ -31,37 +31,40 @@ export default class extends Controller {
       {
         name          : 'Date',
         valuePath     : 'startsAt',
-        isSortable: false,
         cellComponent : 'ui-table/cell/cell-event-date'
 
       },
       {
         name          : 'Roles',
         valuePath     : 'roles',
-        cellComponent : 'ui-table/cell/cell-roles'
+        cellComponent : 'ui-table/cell/cell-roles',
+        isSortable    : false
       },
       {
         name          : 'Sessions',
         valuePath     : 'sessions',
-        isSortable: false,
+        isSortable    : false,
         cellComponent : 'ui-table/cell/cell-sessions-dashboard'
       },
       {
         name          : 'Speakers',
         valuePath     : 'speakers',
-        cellComponent : 'ui-table/cell/cell-speakers-dashboard'
+        cellComponent : 'ui-table/cell/cell-speakers-dashboard',
+        isSortable    : false
 
       },
       {
         name          : 'Tickets',
         valuePath     : 'tickets',
-        cellComponent : 'ui-table/cell/cell-tickets'
+        cellComponent : 'ui-table/cell/cell-tickets',
+        isSortable    : false
 
       },
       {
         name          : 'Public URL',
         valuePath     : 'url',
-        cellComponent : 'ui-table/cell/cell-link'
+        cellComponent : 'ui-table/cell/cell-link',
+        isSortable    : false
       }
     ];
   }
@@ -72,7 +75,7 @@ export default class extends Controller {
     this.model.data.forEach(row => {
       rows.pushObject({
         name     : row,
-        startsAt : row.startsAt,
+        startsAt : row,
         roles    : row,
         sessions : row,
         speakers : row,
@@ -100,19 +103,21 @@ export default class extends Controller {
 
   @action
   openDeleteEventModal(id, name) {
-    this.set('isEventDeleteModalOpen', true);
-    this.set('confirmName', '');
-    this.set('eventName', name);
-    this.set('eventId', id);
+    this.setProperties({
+      isEventDeleteModalOpen : true,
+      confirmName            : '',
+      eventName              : name,
+      eventId                : id
+    });
   }
 
   @action
   async deleteEvent() {
     this.set('isLoading', true);
 
     try {
-      const event = await this.store.findRecord('event', this.eventId, { backgroundReload: false });
-      event.destroyRecord();
+      const event = this.store.peekRecord('event', this.eventId, { backgroundReload: false });
+      await event.destroyRecord();
       this.notify.success(this.l10n.t('Event has been deleted successfully.'));
       this.send('refreshRoute');
     } catch (e) {

app/components/tables/utilities/search-box.js

@@ -1,8 +1,10 @@
-<table class="ui table">
-  {{yield (hash
-            api=api
-            head=(component "ember-thead" api=api)
-            body=(component "ember-tbody" api=api)
-            foot=(component "ember-tfoot" api=api)
-          )}}
-</table>
+<div class="resize-container">
+  <table class="ui unstackable table">
+    {{yield (hash
+              api=api
+              head=(component "ember-thead" api=api)
+              body=(component "ember-tbody" api=api)
+              foot=(component "ember-tfoot" api=api)
+            )}}
+  </table>
+</div>

app/components/ui-table/cell/cell-actions-test.js

@@ -22,7 +22,6 @@ export function initialize(application) {
   inject('routing', 'service:-routing');
   inject('cookies', 'service:cookies');
   inject('infinity', 'service:infinity');
-  inject('headData', 'service:headData');
   application.inject('component', 'router', 'service:router');
 }