amend error handling according to status

Author: uds5501

app/controllers/events/view/tickets/orders/list.js

@@ -90,8 +90,8 @@ export default Controller.extend({
         if (error.status === 429) {
           this.notify.error(this.l10n.t('Only 5 resend actions are allowed in a minute'));
         }
-        if (error.errors[0].detail) {
-          this.notify.error(this.l10n.t(error.errors[0].detail));
+        if (error.status === 422) {
+          this.notify.error(this.l10n.t('Only completed and placed orders can be confirmed'));
         }
       }
     }

app/services/loader.js

@@ -6,7 +6,7 @@ import { buildUrl } from 'open-event-frontend/utils/url';
 import httpStatus from 'http-status';
 import objectToFormData from 'object-to-formdata';
 import fetch from 'fetch';
-import { clone, assign, merge } from 'lodash-es';
+import { clone, assign, merge, pick, isString } from 'lodash-es';
 const bodyAllowedIn = ['PATCH', 'POST', 'PUT'];
 
 export default Service.extend({
@@ -94,20 +94,17 @@ export default Service.extend({
 
     if (!response.ok) {
       const defaultMessage = httpStatus[response.status];
-      if (parsedResponse) {
-        throw parsedResponse;
-      }
-      if (response.status === 429) {
-        throw {status : 429, message : 'TOO MANY REQUESTS'};
-      }
-      throw new Error(
-        getErrorMessage(
+      const errorResponse = pick(response, ['status', 'ok', 'statusText', 'headers', 'url']);
+      errorResponse.statusText = defaultMessage;
+      errorResponse.response = parsedResponse;
+      errorResponse.errorMessage = isString(parsedResponse) ? parsedResponse
+        : getErrorMessage(
           response.statusText,
           defaultMessage
             ? `${response.status} - ${defaultMessage}`
             : `Could not make ${fetchOptions.type} request to ${fetchOptions.url}`
-        )
-      );
+        );
+      throw errorResponse;
     }
     return parsedResponse;
   },