-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create windows executable #14
Comments
Gday @stefanjudis I'd be happy to take a bit of a look at this. I've succesfully compiled an electron app on my windows machine before although using a previous version of electron so I'll take a look at what is involved in the newer versions. PS Forrest looks like a handy little app, well done! |
Thx. :) Yeah compiling wouldn't be a big issues I think. Shell handling is probably more troublesome as Forrest currently opens terminal sessions in the background and navigates to the given folders. Let me know, when I can help somehow. :) |
Gday @stefanjudis , Well as you suspected I've run into an issue with the child_pty module in the sessions.js which is being used for spawning child processes, it appears that this module isn't windows friendly. I've attempted to replace it with a few other modules such as cross-spawn-sync without much joy. Anyway I'll keep digging to see if I can get something going although I'm open to suggestions :) |
The thing here is, that just spawning the given command is not enough. This was my first approach, and this worked fine to a given point. But then it I discovered that streams are not a reliable thing here. So the approach has to stay spawning a new shell, I think. But yeah didn't dig much into it more as +hyperterm uses it, which is nice for looking for solutions. But anyway, thanks and good luck. Really appreciated. :) |
No description provided.
The text was updated successfully, but these errors were encountered: