Write term size in compress buffer in GetOneTerm when reading from fi… #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The parform valgrind failure on the new test is present on the master branch also. |
Collaborator
Author
|
@tueda if you are happy with skipping the test under parform valgrind here, I think we can merge this one (after squashing the test skip commit into the other). |
Collaborator
|
OK, go ahead. |
…le and off compress In the case if "Off Compress;" the term size was not written into the compress buffer when reading from a file, and term compression is off. This results in terms which are incomplete or have extra junk on the end going through Generator; the rest is chaos. The test is not valgrind clean for parform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le and off compress
In the case if "Off Compress;" the term size was not written into the compress buffer when reading from a file, and term compression is off.
This results in terms which are incomplete or have extra junk on the end going through Generator; the rest is chaos.
Fixes #214