Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GF profile: DESC check to ban the word "free" from GF family descriptions #3682

Open
davelab6 opened this issue Mar 30, 2022 · 0 comments
Open
Assignees
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent P1 Quick Profile: Google Fonts

Comments

@davelab6
Copy link
Contributor

Observed behaviour

The word "free" appears in DESC files but this may be misleading so we should use other words.

Related PRs are google/fonts#4443 and google/fonts#4444

We need a FB check to ensure the word (or its stems, freely, etc) doesn't re-enter, that will be run as part of the github.com/google/fonts repo CI.

Expected behaviour

FAIL any family with *free* in the DESC, unless its part of an allow-list with items like "free press" and so on.

Resources and exact process needed to replicate

I'll follow up on this issue with that list.

@davelab6 davelab6 added P1 Quick P0 Urgent New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id labels Mar 30, 2022
@davelab6 davelab6 added this to the 0.8.10 milestone Mar 30, 2022
@felipesanches felipesanches self-assigned this Mar 30, 2022
@felipesanches felipesanches modified the milestones: 0.8.10, 0.8.9, 0.8.x series Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent P1 Quick Profile: Google Fonts
Projects
None yet
Development

No branches or pull requests

3 participants