Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update breaks Spotify Card? #461

Closed
joq3 opened this issue Oct 2, 2024 · 6 comments · Fixed by #462
Closed

Latest update breaks Spotify Card? #461

joq3 opened this issue Oct 2, 2024 · 6 comments · Fixed by #462
Assignees
Labels
bug Something isn't working

Comments

@joq3
Copy link

joq3 commented Oct 2, 2024

After updating to spotcast 3.8.2 the spotify-card broke: https://github.com/custom-cards/spotify-card
From what I understand it is the same creator, which is no longer with us, and there is no support or maintainer on the spotify-card.

Is it possible to adjust spotcast integration to not break spotify-card or does this have to be fixed in the spotify-card?

@joq3 joq3 added the bug Something isn't working label Oct 2, 2024
@Pirol62
Copy link

Pirol62 commented Oct 2, 2024

Yes, same here

@PerSterin
Copy link

If you have this error, change line 146 of init.py. and restart HA. See error in logger below.

From: resp = get_spotify_devices(spotify_media_player)
To: resp = get_spotify_devices(spotify_media_player, hass)

This solved my problem

Logger: homeassistant
Source: custom_components/spotcast/init.py:146
integration: Spotcast (documentation, issues)
First occurred: 15:38:48 (4 occurrences)
Last logged: 15:39:16

Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
File "/config/custom_components/spotcast/helpers.py", line 122, in run
return await loop.run_in_executor(executor, pfunc)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/spotcast/init.py", line 146, in get_devices
resp = get_spotify_devices(spotify_media_player)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: get_spotify_devices() missing 1 required positional argument: 'hass'

@geoffoxholm
Copy link

the line in question:

resp = get_spotify_devices(spotify_media_player)

is clearly broken, as it's imported from here:

def get_spotify_devices(spotify_media_player: SpotifyMediaPlayer, hass):

@geoffoxholm
Copy link

Opened PR #462 to address this.

@PerSterin
Copy link

@geoffoxholm
Yup, probably, I haven't looked at what was changed in between
3.8.1 → 3.8.2
Great then we will get a new Spotcast release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@geoffoxholm @joq3 @Pirol62 @fcusson @PerSterin and others