From 40ad3af3088e07e44f2b7877ca24790bc31d8304 Mon Sep 17 00:00:00 2001 From: Felix Cusson <60357894+Darkfull-Dante@users.noreply.github.com> Date: Fri, 5 Nov 2021 11:16:24 -0400 Subject: [PATCH 1/4] added code review template --- .github/PULL_REQUEST_TEMPLATE/code_review.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/code_review.md diff --git a/.github/PULL_REQUEST_TEMPLATE/code_review.md b/.github/PULL_REQUEST_TEMPLATE/code_review.md new file mode 100644 index 00000000..d88d2ae6 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/code_review.md @@ -0,0 +1,11 @@ +## Docker +- [] spotcast integration load successfully +- [] spotcast sensor load successfully +- [] static uri request working +- [] search request working + +## Raspberry Pi +- [] spotcast integration load successfully +- [] spotcast sensor load successfully +- [] static uri request working +- [] search request working \ No newline at end of file From 5f65409783dd93a0574ab6dc348e591852f12588 Mon Sep 17 00:00:00 2001 From: Felix Cusson <60357894+Darkfull-Dante@users.noreply.github.com> Date: Thu, 16 Dec 2021 11:59:50 -0500 Subject: [PATCH 2/4] correction for #267 --- custom_components/spotcast/spotcast_controller.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/custom_components/spotcast/spotcast_controller.py b/custom_components/spotcast/spotcast_controller.py index 9c09f74b..7f740a6a 100644 --- a/custom_components/spotcast/spotcast_controller.py +++ b/custom_components/spotcast/spotcast_controller.py @@ -206,6 +206,14 @@ def get_spotify_device_id(self, account, spotify_device_id, device_name, entity_ ) return spotify_device_id + + def _clean_uri(self, uri): + + # remove anything after ? + uri = uri.split("?")[0] + + return uri + def play( self, client, @@ -220,6 +228,10 @@ def play( uri, spotify_device_id, ) + + # clean uri + uri = self._clean_uri(uri) + if uri.find("show") > 0: show_episodes_info = client.show_episodes(uri) if show_episodes_info and len(show_episodes_info["items"]) > 0: From ce09ba8a92d94d2236a964b641e89beabadd53f9 Mon Sep 17 00:00:00 2001 From: Felix Cusson <60357894+Darkfull-Dante@users.noreply.github.com> Date: Thu, 16 Dec 2021 12:01:29 -0500 Subject: [PATCH 3/4] make bump --- Makefile | 2 +- custom_components/spotcast/manifest.json | 2 +- setup.cfg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 7034b184..7fd1b1aa 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -__VERSION__ = "3.6.20" +__VERSION__ = "3.6.21" bump: bump2version --allow-dirty --current-version $(__VERSION__) patch Makefile custom_components/spotcast/manifest.json diff --git a/custom_components/spotcast/manifest.json b/custom_components/spotcast/manifest.json index 10e95386..0e1e0f22 100644 --- a/custom_components/spotcast/manifest.json +++ b/custom_components/spotcast/manifest.json @@ -7,7 +7,7 @@ "requirements": [ "spotify_token==1.0.0" ], - "version": "v3.6.20", + "version": "v3.6.21", "dependencies": [ "spotify" ], diff --git a/setup.cfg b/setup.cfg index 582d34b7..10af6db7 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,5 +1,5 @@ [bumpversion] -current_version = 3.6.20 +current_version = 3.6.21 [flake8] exclude = .venv,.git,.tox,docs,venv,bin,lib,deps,build From 224aa5bbf35679e90248707496405cab31091200 Mon Sep 17 00:00:00 2001 From: Felix Cusson <60357894+Darkfull-Dante@users.noreply.github.com> Date: Thu, 16 Dec 2021 12:09:52 -0500 Subject: [PATCH 4/4] make bump --- Makefile | 2 +- custom_components/spotcast/manifest.json | 2 +- setup.cfg | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 7fd1b1aa..d68bcee8 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,4 @@ -__VERSION__ = "3.6.21" +__VERSION__ = "3.6.23" bump: bump2version --allow-dirty --current-version $(__VERSION__) patch Makefile custom_components/spotcast/manifest.json diff --git a/custom_components/spotcast/manifest.json b/custom_components/spotcast/manifest.json index b2768bca..a789856f 100644 --- a/custom_components/spotcast/manifest.json +++ b/custom_components/spotcast/manifest.json @@ -7,7 +7,7 @@ "requirements": [ "spotify_token==1.0.0" ], - "version": "v3.6.22", + "version": "v3.6.23", "dependencies": [ "spotify" ], diff --git a/setup.cfg b/setup.cfg index 10af6db7..cb81a57d 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,5 +1,5 @@ [bumpversion] -current_version = 3.6.21 +current_version = 3.6.23 [flake8] exclude = .venv,.git,.tox,docs,venv,bin,lib,deps,build