Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DropDown] Merge Submenu-Positioning Fix #194

Closed
lubber-de opened this issue Oct 22, 2018 · 2 comments
Closed

[DropDown] Merge Submenu-Positioning Fix #194

lubber-de opened this issue Oct 22, 2018 · 2 comments
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.0

Comments

@lubber-de
Copy link
Member

lubber-de commented Oct 22, 2018 •
edited
Loading

Description

SUI 2.4.2 includes It exists a serious Bugfix for upward/downward positioning of submenus when Dropdown are too narrow to the bottom of the browser viewport

Please try to merge the original commit
Semantic-Org/Semantic-UI@601853c

Closes

Semantic-Org/Semantic-UI#6007
Semantic-Org/Semantic-UI#3505
Semantic-Org/Semantic-UI#6700
@ColinFrick
Copy link
Member

This is not yet merged into SUI (and not released with SUI 2.4.2).
Here is the original pull request: Semantic-Org/Semantic-UI#6458

@lubber-de
Copy link
Member Author

OK, was too late yesterday.. Anyway we should implement this fix aswell asap IMHO

Will adjust the issue title accordingly

@lubber-de lubber-de changed the title [DropDown] Merge Submenu-Positioning Fix from SUI 2.4.2 [DropDown] Merge Submenu-Positioning Fix Oct 23, 2018
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI labels Oct 24, 2018
@lubber-de lubber-de mentioned this issue Dec 3, 2018
Merged
@y0hami y0hami added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 5, 2018
@lubber-de lubber-de added this to the 2.7.0 milestone Dec 5, 2018
This was referenced Dec 21, 2018
Merged
Merged
@y0hami y0hami closed this as completed Dec 21, 2018
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
3 participants
@ColinFrick @y0hami @lubber-de