-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hacks): cursor jumps in cmdline #937
Conversation
LGTM. Tested on macOS 14.6.1 with
|
Would you be willing to share the line of config to set redraw to false?? |
you can get it in the commit, see here |
Thank you so much!! |
That cursor redraw is there for a reason, so I can't merge this..... |
So it seems that this is probably the right fix afterall :) I thought this was set to Will further debug and see if this is good to merge. |
@folke I can confirm on Windows changing this to false as well fixes it. But strangely enough instead of changing cursor = false. Adding Not sure what the correct fix per say is. if not Util.is_search() then
if vim.api.nvim__redraw then
vim.api.nvim__redraw({ flush = true, cursor = true, win = Cmdline.win() })
else
vim.cmd.redraw()
end
end |
🤖 I have created a release *beep* *boop* --- ## [4.5.1](v4.5.0...v4.5.1) (2024-09-18) ### Bug Fixes * dont redraw when exiting. Fixes [#936](#936). Fixes [#921](#921) ([8c6a024](8c6a024)) * **hacks:** dont close timer multiple times during exit ([86a4891](86a4891)) * **hacks:** only redraw cursor when cmdline is active. Fixes [#950](#950). Fixes [#937](#937). Fixes [#923](#923) ([3373ab5](3373ab5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fix #931 #923
After setting the
cursor
ofnvim__redraw
tofalse
.the cursor no longer jumps, it works well for me.