Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check item.detail is type of table #595

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: check item.detail is type of table #595

merged 1 commit into from
Sep 25, 2023

Conversation

devswi
Copy link
Contributor

@devswi devswi commented Sep 18, 2023

CleanShot 2023-09-18 at 16 54 38@2x

noice.nvim/lua/noice/lsp/override.lua

Line 20 in 74c2902

if item.detail and not ret:find(item.detail, 1, true) then

item.detail sometimes is type of table and it will cause ret:find function throw a exception.

@folke folke merged commit 3670766 into folke:main Sep 25, 2023
@folke
Copy link
Owner

folke commented Sep 25, 2023

thanks!

@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
@devswi devswi deleted the bugfix/check-detail-is-table branch September 25, 2023 08:14
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devswi @folke