Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<80>kb character in notifications #131

Closed
pBorak opened this issue Oct 26, 2022 · 8 comments · Fixed by #639
Closed

<80>kb character in notifications #131

pBorak opened this issue Oct 26, 2022 · 8 comments · Fixed by #639
Labels
bug Something isn't working upstream Issue is caused by a dependency (like Neovim)

Comments

@pBorak
Copy link

pBorak commented Oct 26, 2022

Describe the bug

Hey, I've noticed that this changes introduced weird behavior when interacting with vim-fugitive.
After doing a git commit within the nvim with the use of vim-fugitive there's an extra <80>kb character present in the notification. See screenshots below

To Reproduce
Steps to reproduce the behavior:

  1. Open fugitive popup
  2. Stage files
  3. hit cc to open the commit window
  4. write commit-msg and hit wq

Expected Behavior
There's no <80kb>

Screenshots
Screenshot 2022-10-26 at 22 01 46

Before 8463b0 it looked this way
Screenshot 2022-10-26 at 22 00 44

@pBorak pBorak added the bug Something isn't working label Oct 26, 2022
@Pheon-Dev
Copy link

Pheon-Dev commented Oct 27, 2022

@folke , can't seem to figure out why issue #142, here, and this one kind of have some sort of problem something in common. I've been facing the same problem too whereby the [SHIFT] key seems to be already pressed then a notification appears whenever the key is actually pressed showing what would have been the result of [SHIFT + ,] which is [<] as illustrated below.
Note: No one pressed the [SHIFT] key, just the [,] key which in itself I mapped it to saving a file(wasn't really using it for [?] search next :-)

image

@pBorak
Copy link
Author

pBorak commented Oct 27, 2022

👍🏻 I have also noticed the issue with < notifications

@folke
Copy link
Owner

folke commented Oct 27, 2022

Check :h shortmess. t option. Standard Neovim behavior

image

@folke
Copy link
Owner

folke commented Oct 27, 2022

@Pheon-Dev #142 is an nvin-notify problem, not Noice.
Your issue #99, is not an issue at all. Your issue #99 was because of a plugin.
All unrelated to this.

This is likely caused by my hack to make keys work in cmdline during substitute. But haven't yet found anything that could cause that.

@folke
Copy link
Owner

folke commented Oct 27, 2022

Just looked it up and <80>kb is indeed the internal code for <backspace>.
Which I do here

vim.api.nvim_input("<space><bs>")

@Pheon-Dev
Copy link

Thanks for the explanation, it makes more sense now. I'll try to config my nvim-notify a bit better to avoid receiving unnecessary messages

@folke folke added the upstream Issue is caused by a dependency (like Neovim) label Oct 29, 2022
@folke
Copy link
Owner

folke commented Oct 29, 2022

Once the upstream issue below is solved, this issue can be solved

@folke folke closed this as completed in 23da4ed Nov 16, 2022
@folke
Copy link
Owner

folke commented Nov 16, 2022

I was able to work around the cursor issue by calling update_screen through ffi, so your issue should no longer happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue is caused by a dependency (like Neovim)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants