Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with VS2017 string_view #657

Closed
alabuzhev opened this issue Feb 16, 2018 · 1 comment
Closed

Not compatible with VS2017 string_view #657

alabuzhev opened this issue Feb 16, 2018 · 1 comment

Comments

@alabuzhev
Copy link
Contributor

In VS2017 basic_string_view::iterator is not a raw pointer but an internal class, _String_view_iterator.

fmt does not expect that and fails to compile:

format.h(3119): error C2664: 'void fmt::basic_parse_context<char,fmt::internal::error_handler>::advance_to(std::_String_view_iterator<_Traits>)': cannot convert argument 1 from 'const char *' to 'std::_String_view_iterator<_Traits>

Note: there is a flaw in the current build system: VS2017 only provides <string_view> header if /std:c++latest is specified. fmt, however, does not set that flag and therefore uses it's own, "fallback" string_view implementation, which renders this issue invisible for your build system.

@vitaut
Copy link
Contributor

vitaut commented Feb 24, 2018

Fixed by using fallback string_view (#664). Thanks for reporting!

@vitaut vitaut closed this as completed Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants