Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ArgMap::init into format.h #560

Closed
Yelnats321 opened this issue Aug 28, 2017 · 2 comments
Closed

Move ArgMap::init into format.h #560

Yelnats321 opened this issue Aug 28, 2017 · 2 comments

Comments

@Yelnats321
Copy link
Contributor

Currently, internal::ArgMap<Char>::init is defined inside format.cc and explicitly instantiated for char and wchar_t, even though the function itself is char type agnostic. This leads to issues using a character type other than these two. The easiest solution is to simply move the function definition into format.h. I am unsure on the compile time impact of such a change, although it would seem to be negligible, especially considering that most other functions are not explicitly instantiated (with the exception of format_float for understandable reasons and FixedBuffer::grow).

@vitaut
Copy link
Contributor

vitaut commented Aug 29, 2017

Seems reasonable. Could you by any chance submit a PR?

@Yelnats321
Copy link
Contributor Author

Yeah sure just give me a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants