Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can (not) control the Unicode support via the CMake FMT_UNICODE option. #4051

Closed
grooverdan opened this issue Jul 4, 2024 · 3 comments
Closed

Comments

@grooverdan
Copy link

version: 11.0.0

It looks like its true, but you can't compile on MSVC without it.

As a subproject the option needs to be enabled for the target_compile_options to be applied.

include/fmt/base.h forces the define to true.

Line 457 will assert if the /utf8 isn't set.

ref: https://buildbot.mariadb.org/#/builders/234/builds/30730/steps/8/logs/stdio

@vitaut
Copy link
Contributor

vitaut commented Jul 4, 2024

Thanks for reporting. Just to clarify: are you trying to disable Unicode support? Setting FMT_UNICODE macro was missing from the CMake config which is fixed in e50c8b6.

@grooverdan
Copy link
Author

I just noticed it was there. I'm happy to enable unicode.

@vitaut
Copy link
Contributor

vitaut commented Jul 5, 2024

Closing as disabling Unicode has been fixed but if there is more to it please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants