Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'fmt::detail::string_scan_buffer' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor] #3884

Closed
enh-google opened this issue Mar 5, 2024 · 1 comment

Comments

@enh-google
Copy link

trying to update AOSP (which has a very recent clang, based off clang 17) to fmtlib 10...

In file included from external/fmtlib/test/scan-test.cc:8:
external/fmtlib/test/scan.h:144:7: error: 'fmt::detail::string_scan_buffer' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
  144 | class string_scan_buffer : public scan_buffer {
      |       ^
external/fmtlib/test/scan.h:269:3: error: 'fmt::detail::file_scan_buffer' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
  269 |   ~file_scan_buffer() { funlockfile(file_); }
      |   ^
2 errors generated.
@vitaut
Copy link
Contributor

vitaut commented Mar 10, 2024

Fixed in c816fa6. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants