Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signed/unsigned error on MSVC 14.36.32532 #3646

Closed
saschasc opened this issue Sep 18, 2023 · 1 comment
Closed

signed/unsigned error on MSVC 14.36.32532 #3646

saschasc opened this issue Sep 18, 2023 · 1 comment

Comments

@saschasc
Copy link
Contributor

The following line leads to a signed/unsigned error on newer MSVC compilers (14.36.32532).

https://github.com/fmtlib/fmt/blame/f6ca4ea1990af67e00358cfe83c19f5aa4df5f19/include/fmt/format.h#L3036

Casting the value to the underlying datatype uint32_t solves the compiler issue.

std::uninitialized_fill_n(bigits_.data(), exp_difference, **static_cast<uint32_t>(0)**);
@saschasc
Copy link
Contributor Author

I will close this issue in favour of the PR #3647

@BrewTestBot BrewTestBot mentioned this issue Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saschasc