Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int128 cannot be used with sign argument #2773

Closed
PredatorCZ opened this issue Feb 16, 2022 · 1 comment
Closed

int128 cannot be used with sign argument #2773

PredatorCZ opened this issue Feb 16, 2022 · 1 comment

Comments

@PredatorCZ
Copy link

fmt/include/fmt/core.h

Lines 2821 to 2823 in 70de324

if (is_integral_type(arg_type_) && arg_type_ != type::int_type &&
arg_type_ != type::long_long_type && arg_type_ != type::char_type) {
this->on_error("format specifier requires signed argument");

Shouldn't be type::int128_type included as well?

@vitaut
Copy link
Contributor

vitaut commented Feb 17, 2022

Good catch, thanks! Fixed in 6a13464.

@vitaut vitaut closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants