Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic_format_arg_store move constructor is not automatically generated #2654

Closed
lucpelletier opened this issue Dec 14, 2021 · 1 comment
Closed

Comments

@lucpelletier
Copy link
Contributor

dynamic_format_arg_store has a copy constructor but no explicitly declared move constructor / move assignment operator. These are not automatically generated and any attempts to call the move constructor of dynamic_format_arg_store results in calling the copy constructor. See the following link for quotes from the c++ standard that explicitly state when assignment operators / constructors are automatically generated:

https://stackoverflow.com/questions/4943958/conditions-for-automatic-generation-of-default-copy-move-ctor-and-copy-move-assi

If library maintainers agree that this is a problem that should be fixed, I'm happy to provide a PR to explicitly declare assignment operators and the move constructor.

@vitaut
Copy link
Contributor

vitaut commented Dec 14, 2021

It is not a problem but a PR would be welcome provided that you have an actual use case that would benefit from this optimization.

@vitaut vitaut closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants