Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few functions in ranges.h need inlining #2481

Closed
palacaze opened this issue Sep 1, 2021 · 5 comments
Closed

A few functions in ranges.h need inlining #2481

palacaze opened this issue Sep 1, 2021 · 5 comments

Comments

@palacaze
Copy link
Contributor

palacaze commented Sep 1, 2021

Recent changes in ranges.h introduced non-templated functions that are not inlined, thus breaking the ODR and triggering compilation errors.
@vitaut
Copy link
Contributor

vitaut commented Sep 1, 2021

Please provide more details and ideally a repro.

@palacaze
Copy link
Contributor Author

palacaze commented Sep 1, 2021

Sure, I created a test then the corresponding fix here https://github.com/palacaze/fmt/tree/ranges-odr

@vitaut
Copy link
Contributor

vitaut commented Sep 1, 2021

Could you submit a PR with the fix since you already have one?

@palacaze
Copy link
Contributor Author

palacaze commented Sep 2, 2021

Would you prefer a PR with only the fix or also the accompanying testcase?

@vitaut
Copy link
Contributor

vitaut commented Sep 2, 2021

Test would be great, thank you!

@vitaut vitaut closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @palacaze