Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer_appender does not conform to std::output_iterator #2195

Closed
burnpanck opened this issue Mar 28, 2021 · 2 comments · Fixed by #2204
Closed

buffer_appender does not conform to std::output_iterator #2195

burnpanck opened this issue Mar 28, 2021 · 2 comments · Fixed by #2204
Labels
enhancement

Comments

@burnpanck
Copy link

I've run into this before with truncating_iterator (see #2156), apparently, the same applies for buffer_appender.

CC @randomnetcat :-)
@foonathan
Copy link
Contributor

Note that there is a proposal that removes the default constructor requirement from output iterator.

@vitaut
Copy link
Contributor

vitaut commented Mar 31, 2021

Should be easy to do similarly to #2158. PR is welcome =).

@randomnetcat randomnetcat mentioned this issue Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make buffer_appender default-constructible when back_insert_iterator is randomnetcat/fmt
3 participants
@vitaut @burnpanck @foonathan