Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override warning #2000

Closed
killerbot242 opened this issue Nov 10, 2020 · 4 comments
Closed

override warning #2000

killerbot242 opened this issue Nov 10, 2020 · 4 comments

Comments

@killerbot242
Copy link
Contributor

Hi, would you mind adjusting the os.h with this little adjusment :

void grow(size_t) override final; <============ added the keyword override

This is to avoid gcc (7.x) to complain that the method can be marked override (seems override/final is not considered a union in this version of the compiler?

many thanks

@vitaut
Copy link
Contributor

vitaut commented Nov 10, 2020

Could you submit a PR?

@killerbot242
Copy link
Contributor Author

will try, let's try to find out how that was done again, lot of effort for adding one word ;-)
but let me try

@killerbot242
Copy link
Contributor Author

killerbot242 commented Nov 10, 2020

branch created, committed, trying to push it, fails.
so unable to create a PR out of it, can't get my change to remote/origin/whatever.

going down the fork road, but now I get old sources ...

@killerbot242
Copy link
Contributor Author

got one, but still don't understand much of this git magic, my master branch of fork remains behind according to github though it has been origin synec like in (https://gist.github.com/CristinaSolana/1885435)

anyhow, till the next PR I am safe now ;-)

#2001

@vitaut vitaut closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants