-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated github CI only runs against C++11 standard #1987
Comments
As I read it, that issue is about moving to Actions. This issue is about how that move to actions changed the behavior of testing. Can you help me understand how this issue duplicates that one? |
The migration from Travis CI to Github Actions is still in progress and is tracked in #1969. Configuration parity is just one minor aspect of it. |
Thank you for the explanation. If you'd like help with that, I would be interested in contributing. |
Sure, a PR to add a C++17 config is welcome. |
When switching from Travis to github CI (roughly cba5970), it seems like the testing for standards other than C++11 was lost.
This issue is relevant because compilers behave differently at different standards. For example, with clang 11.0.0, a pedantic build of fmt succeeds in C++11 mode but fails with the following error in C++20 mode.
I think the correct fix here is to add C++ standards to the build matrix and I would be happy to submit a PR for that work, if there's interest. If that's not palatable then I would like to see the setup should return to the way it was previously with C++11 being tested in g++-4.8, C++14 being tested in gcc-6, and C++17 being tested in gcc-8.
The text was updated successfully, but these errors were encountered: