Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visibility attribute not supported warnings on mingw64 #1743

Closed
mizvekov opened this issue Jun 25, 2020 · 1 comment
Closed

visibility attribute not supported warnings on mingw64 #1743

mizvekov opened this issue Jun 25, 2020 · 1 comment

Comments

@mizvekov
Copy link

mizvekov commented Jun 25, 2020

Compiling with GCC 10.1 for windows (mingw64) produces a bunch of these kinds of warnings:

fmt/format-inl.h: In member function '__dt_del ':
fmt\format-inl.h(213,18): warning G2331D7DD: visibility attribute not supported in this configuration; ignored [-Wattributes]
    213 | FMT_API FMT_FUNC format_error::~format_error() FMT_NOEXCEPT = default;

So yeah, visibility attribute is not supported for windows target.

Note: __has_atttribute is not an option to solve this, it will still evaluate to true.

@vitaut
Copy link
Contributor

vitaut commented Jun 26, 2020

Removed the non-portable attribute in 3135d95. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants