Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning when using spdlog #1160

Closed
ranjan-2209 opened this issue May 14, 2019 · 4 comments
Closed

warning when using spdlog #1160

ranjan-2209 opened this issue May 14, 2019 · 4 comments

Comments

@ranjan-2209
Copy link

gabime/spdlog#1051

I am using spdlog with VS 2019. I have copy pasted the spdlog folder as given in the docs.
I got the following warnings:

  1. spdlog\fmt\bundled\format-inl.h(722): warning C4244: 'argument': conversion from 'const unsigned __int64' to 'int', possible loss of data
  2. spdlog\fmt\bundled\format-inl.h(722): note: This diagnostic occurred in the compiler generated function 'std::enable_if<sizeof(Double)==,bool>::type fmt::v5::internal::grisu2_format(Double,fmt::v5::internal::buffer &,fmt::v5::core_format_specs)'
  3. spdlog\fmt\bundled\format-inl.h(722): warning C4244: 'argument': conversion from 'const unsigned __int64' to 'int', possible loss of data
  4. spdlog\fmt\bundled\format-inl.h(722): note: This diagnostic occurred in the compiler generated function 'std::enable_if<sizeof(Double)==,bool>::type fmt::v5::internal::grisu2_format(Double,fmt::v5::internal::buffer &,fmt::v5::core_format_specs)'
@vitaut
Copy link
Contributor

vitaut commented May 14, 2019

Thanks for reporting, but this has been fixed already.

@vitaut vitaut closed this as completed May 14, 2019
@ranjan-2209
Copy link
Author

I have used this recently. I got these warning.
Anyways, I will check it again.

@gabime
Copy link
Contributor

gabime commented May 14, 2019

@vitaut Is there an estimate for the next minor release date? I would like to integrate it in spdlog.

@vitaut
Copy link
Contributor

vitaut commented May 14, 2019

Is there an estimate for the next minor release date?

Some time after WG21 paper submission deadline (17 June), not sure exactly when yet. Floating point needs a bit more work and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants