Added missing typename to FMT_STRING. (#1089)

* Added missing typename to FMT_STRING. This is so that FMT_STRING can be used in a template.
fmtlib · Mar 21, 2019 · 7ad3015 · 7ad3015
1 parent f0b572d
commit 7ad3015
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/include/fmt/format.h b/include/fmt/format.h
@@ -3619,7 +3619,8 @@ FMT_END_NAMESPACE
       }                                                                   \
     } result;                                                             \
     /* Suppress Qt Creator warning about unused operator. */              \
-    (void)static_cast<fmt::basic_string_view<str::char_type>>(result);    \
+    (void)static_cast<fmt::basic_string_view<typename str::char_type>>(   \
+        result);                                                          \
     return result;                                                        \
   }()
 

diff --git a/test/format-test.cc b/test/format-test.cc
@@ -2475,6 +2475,15 @@ TEST(FormatTest, VFormatTo) {
   EXPECT_EQ(L"42", w);
 }
 
+template <typename T> static std::string FmtToString(const T& t) {
+  return fmt::format(FMT_STRING("{}"), t);
+}
+
+TEST(FormatTest, FmtStringInTemplate) {
+  EXPECT_EQ(FmtToString(1), "1");
+  EXPECT_EQ(FmtToString(0), "0");
+}
+
 #endif  // FMT_USE_CONSTEXPR
 
 TEST(FormatTest, ConstructU8StringViewFromCString) {