Do not compute localtime twice

fmtlib · May 18, 2021 · 4b9c9b9 · ecorm · May 18, 2021 · ecorm
1 parent 7a33f5e
commit 4b9c9b9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/include/fmt/chrono.h b/include/fmt/chrono.h
@@ -411,14 +411,16 @@ struct formatter<std::chrono::time_point<std::chrono::system_clock, std::chrono:
   template <typename FormatContext>
   auto format(std::chrono::time_point<std::chrono::system_clock> val,
               FormatContext& ctx) -> decltype(ctx.out()) {
-    std::tm time = localtime(val);
+    std::tm time;
     auto epoch = val.time_since_epoch();
     auto seconds = std::chrono::duration_cast<std::chrono::seconds>(epoch);
     auto subseconds = std::chrono::duration_cast<std::chrono::duration<Rep, Period>>(epoch - seconds);
 
     if (subseconds < subseconds.zero()) {
       time = localtime(val - std::chrono::seconds{1});
       subseconds = std::chrono::seconds{1} + subseconds;
+    } else {
+      time = localtime(val);
     }
 
     if (subseconds.count() > 0) {