From 265a7bfcc8d68a40275d49fa5aef4217eceddd0e Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Sun, 15 Sep 2024 10:01:55 +0200 Subject: [PATCH 1/4] Update GitHub actions --- .github/workflows/check-formatting.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-formatting.yml b/.github/workflows/check-formatting.yml index 10eaf52..5b76223 100644 --- a/.github/workflows/check-formatting.yml +++ b/.github/workflows/check-formatting.yml @@ -14,12 +14,12 @@ jobs: name: Check formatting steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Go environment - uses: actions/setup-go@v2 + uses: actions/setup-go@v4 with: - go-version: '^1.22' + go-version: '^1.23' - name: Install formatters run: | From 1e806a3c9b6a3c1519c14ff73dc655905716cc8c Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Sun, 15 Sep 2024 10:04:30 +0200 Subject: [PATCH 2/4] Update run-tests-externally.yml --- .github/workflows/run-tests-externally.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests-externally.yml b/.github/workflows/run-tests-externally.yml index ce8b90b..58b94a5 100644 --- a/.github/workflows/run-tests-externally.yml +++ b/.github/workflows/run-tests-externally.yml @@ -54,7 +54,7 @@ jobs: BAZELISK_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Set up JDK uses: actions/setup-java@v4 @@ -63,7 +63,7 @@ jobs: java-version: ${{ matrix.jdk }} - name: Mount Bazel disk cache - uses: actions/cache@v2 + uses: actions/cache@v4 with: path: ${{ matrix.cache }} key: bazel-disk-cache-${{ matrix.bazel }}-${{ matrix.os }}-${{ matrix.jdk }} @@ -91,7 +91,7 @@ jobs: - name: Upload test logs if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: testlogs-${{ matrix.bazel}}-${{ matrix.os }}-${{ matrix.jdk }} # https://github.com/actions/upload-artifact/issues/92#issuecomment-711107236 From 803aad8d37bd9727f2363cc5928abed89c03b279 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Sun, 15 Sep 2024 10:04:53 +0200 Subject: [PATCH 3/4] Update run-tests-internally.yml --- .github/workflows/run-tests-internally.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests-internally.yml b/.github/workflows/run-tests-internally.yml index 71072e8..d63295e 100644 --- a/.github/workflows/run-tests-internally.yml +++ b/.github/workflows/run-tests-internally.yml @@ -19,7 +19,7 @@ jobs: name: Build and test internally (ubuntu-latest, Bazel last_green module, JDK 21) steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Set up JDK uses: actions/setup-java@v4 @@ -28,7 +28,7 @@ jobs: java-version: 21 - name: Mount Bazel disk cache - uses: actions/cache@v2 + uses: actions/cache@v4 with: path: "/home/runner/.cache/bazel-disk" key: bazel-disk-cache-internal @@ -45,7 +45,7 @@ jobs: - name: Upload test logs if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: testlogs-internal # https://github.com/actions/upload-artifact/issues/92#issuecomment-711107236 From a8284ba1acdd466cd3f52f232c326337ef272d80 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Sun, 15 Sep 2024 13:50:44 +0200 Subject: [PATCH 4/4] Remove testlog upload --- .github/workflows/run-tests-externally.yml | 10 ---------- .github/workflows/run-tests-internally.yml | 9 --------- 2 files changed, 19 deletions(-) diff --git a/.github/workflows/run-tests-externally.yml b/.github/workflows/run-tests-externally.yml index 58b94a5..2eb4f82 100644 --- a/.github/workflows/run-tests-externally.yml +++ b/.github/workflows/run-tests-externally.yml @@ -88,13 +88,3 @@ jobs: sudo apt install clang-14 llvm-14 bazelisk coverage --config=ci --disk_cache=${{ matrix.cache }} --profile=${{ github.workspace }}/profile.gz ${{ matrix.bazel_extra_args }} //... ./verify_coverage.sh - - - name: Upload test logs - if: always() - uses: actions/upload-artifact@v4 - with: - name: testlogs-${{ matrix.bazel}}-${{ matrix.os }}-${{ matrix.jdk }} - # https://github.com/actions/upload-artifact/issues/92#issuecomment-711107236 - path: | - ${{ github.workspace }}/tests/bazel-testlogs*/**/test.log - ${{ github.workspace }}/profile.gz diff --git a/.github/workflows/run-tests-internally.yml b/.github/workflows/run-tests-internally.yml index d63295e..4e94d96 100644 --- a/.github/workflows/run-tests-internally.yml +++ b/.github/workflows/run-tests-internally.yml @@ -42,12 +42,3 @@ jobs: env: USE_BAZEL_VERSION: "last_green" run: bazelisk test --disk_cache="/home/runner/.cache/bazel-disk" //... - - - name: Upload test logs - if: always() - uses: actions/upload-artifact@v4 - with: - name: testlogs-internal - # https://github.com/actions/upload-artifact/issues/92#issuecomment-711107236 - path: | - ${{ github.workspace }}/bazel-testlogs*/**/test.log