diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkTransition.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkTransition.java index 64a0de883867a6..9f1518591f2896 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkTransition.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkTransition.java @@ -267,31 +267,39 @@ public static Map validate( Map buildSettingPackages, Map toOptions) throws TransitionException { - // Collect settings changed during this transition and their types. This includes settings that - // were only used as inputs as to the transition and thus had their default values added to the - // fromOptions, which in case of a no-op transition directly end up in toOptions. - Map changedSettingToRule = Maps.newHashMap(); + // Collect settings that are inputs or outputs of the transition together with their types. + // Output setting values will be validated and removed if set to their default. + Map inputAndOutputSettingsToRule = Maps.newHashMap(); + // Collect settings that were only used as inputs to the transition and thus possibly had their + // default values added to the fromOptions. They will be removed if set to ther default, but + // should not be validated. + Set