Fixing error when phigaro output was empty #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmalmeida
added a commit
that referenced
this pull request
Jun 29, 2022
* adding checkIfExists rules to input loading * Update build.sh * fixed report if else statement * updated version and changelog * fix example samplesheet url * Create nf-core-bacannot-compare_logo_dark.png * Update phigaro.nf * Update CHANGELOG.md * Update CHANGELOG.md
fmalmeida
added a commit
that referenced
this pull request
Sep 9, 2022
* first bakta addition test * Fixing error when phigaro output was empty (#55) (#56) * adding checkIfExists rules to input loading * Update build.sh * fixed report if else statement * updated version and changelog * fix example samplesheet url * Create nf-core-bacannot-compare_logo_dark.png * Update phigaro.nf * Update CHANGELOG.md * Update CHANGELOG.md * Update .gitignore * Update bacannot.nf * workflow runs from top to bottom * workflow correctly working * changing version manifest * explaining how to use bakta * adding variables to generic annotation * adding victors backup db * report_general understands bakta * report_resistance understands bakta * update hmmer to working version with PGAP * update hmmer to working version with PGAP (#59) * update hmmer to working version with PGAP (#59) (#60) * Update resfinder2gff.py * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update docker.config * download db if not available * Update merge_annotations.nf * Update merge_annotations.nf * update process label * Update merge_annotations.nf * fix docker file ownerships * added retry label for bakta
fmalmeida
added a commit
that referenced
this pull request
Sep 9, 2022
* update hmmer to working version with PGAP * update hmmer to working version with PGAP (#59) (#60) * Adding option for using `bakta` (#58) * first bakta addition test * Fixing error when phigaro output was empty (#55) (#56) * adding checkIfExists rules to input loading * Update build.sh * fixed report if else statement * updated version and changelog * fix example samplesheet url * Create nf-core-bacannot-compare_logo_dark.png * Update phigaro.nf * Update CHANGELOG.md * Update CHANGELOG.md * Update .gitignore * Update bacannot.nf * workflow runs from top to bottom * workflow correctly working * changing version manifest * explaining how to use bakta * adding variables to generic annotation * adding victors backup db * report_general understands bakta * report_resistance understands bakta * update hmmer to working version with PGAP * update hmmer to working version with PGAP (#59) * update hmmer to working version with PGAP (#59) (#60) * Update resfinder2gff.py * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update docker.config * download db if not available * Update merge_annotations.nf * Update merge_annotations.nf * update process label * Update merge_annotations.nf * fix docker file ownerships * added retry label for bakta * update changelog
fmalmeida
added a commit
that referenced
this pull request
Dec 19, 2022
* update hmmer to working version with PGAP * update hmmer to working version with PGAP (#59) (#60) * Adding option for using `bakta` (#58) * first bakta addition test * Fixing error when phigaro output was empty (#55) (#56) * adding checkIfExists rules to input loading * Update build.sh * fixed report if else statement * updated version and changelog * fix example samplesheet url * Create nf-core-bacannot-compare_logo_dark.png * Update phigaro.nf * Update CHANGELOG.md * Update CHANGELOG.md * Update .gitignore * Update bacannot.nf * workflow runs from top to bottom * workflow correctly working * changing version manifest * explaining how to use bakta * adding variables to generic annotation * adding victors backup db * report_general understands bakta * report_resistance understands bakta * update hmmer to working version with PGAP * update hmmer to working version with PGAP (#59) * update hmmer to working version with PGAP (#59) (#60) * Update resfinder2gff.py * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update addBedtoolsIntersect.R * Update docker.config * download db if not available * Update merge_annotations.nf * Update merge_annotations.nf * update process label * Update merge_annotations.nf * fix docker file ownerships * added retry label for bakta * update changelog * changing to new version * add falmeida-py scripts to docker * Create generate_dockers.sh * Minor improvements for custom database annotation (#67) * Add step making Blast DB when annotating custom db Blast database throw error for no alias or index file found for nucleotide database, when using blastn. Thus, make blast database before execute blastn to custom database on genome. * Remove space when generate link in Shiny markdown Whitespace occurs when generated links for custom database report in Shiny markdown. Specify seperate string to emtpy string to fix this. * fix: script was calling an out of bounds value * handle exceptions and missing values * increment test profile * also build for proteins * Use correct version of customdb_gffs in REPORTS module Co-authored-by: fmalmeida <[email protected]> * fixed docker images * resfinder now uses conda env * rgi does not have --exclude_nudge anymore * add circos conf files * fix indentation * add circos sub-workflow calling * add circos tool * added karyotype and gc_skew modules * fix indentation * modules now have a channel suitable for summary generation * include summary generation module * update docker image * add aro index tsv * add amrfinder2tsv module * add bacannot json summary generation * update docker images * add new modules * added binaries for circos plot * update docker files * add label to module * finalise modules preparing data for circos * include whole circos 'pathway' in workflow * add circos module * circos plot currently functional * re-organised circos outputs * ameliorate default version of circos plot * fixed docker image * fixed custom annotation problem in server * added circos plot with easy_circos * circos plot properly being generated * update changelog * update readme * update documentation * fix tool name * fix dir * update indentation * fixed schema * add pipefail * fix docker image Co-authored-by: Cy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version contains:
checkIfExistsstatements when loading file to make sure that user is pointing to files that exists and did not misspelled themThanks to @fetyj for spotting these issues.