Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools to use own docker image #69

Closed
Tracked by #88
fmalmeida opened this issue Oct 29, 2022 · 3 comments · Fixed by #91
Closed
Tracked by #88

Tools to use own docker image #69

fmalmeida opened this issue Oct 29, 2022 · 3 comments · Fixed by #91
Labels
enhancement New feature or request
Milestone

Comments

@fmalmeida
Copy link
Owner

Adapt the pipeline so that modules use smaller docker images, preferably, one image per module.

For example, AMRFinderPlus to use the quay.io image.

Since some tools are regularly updated and others don’t, this would allow an easier manner of updating some software versions.

@fmalmeida fmalmeida added the enhancement New feature or request label Oct 29, 2022
@fmalmeida fmalmeida added this to the v3.3 milestone Mar 3, 2023
@fmalmeida
Copy link
Owner Author

So one can easily copy and change software versions, instead of having images define within the modules as it is now, all public images should be defined in a single config file, so, if desired by users, they can quickly copy the contents and update the pipeline execution by giving an additional custom conig with -c.

It is not a problem that some tools still use the custom built docker images bundled with the pipeline. The goal of this issue was to change to the public images, all the modules that could work with them. The modules, that did not work with public images, will still use the custom ones generated by us.

@fmalmeida fmalmeida linked a pull request Mar 31, 2023 that will close this issue
@fmalmeida
Copy link
Owner Author

Only missing to-do for release:

  • Decide how to allow users to quickly customise the version of biocontainers images to use ... To it as a parameter where users could select each version tag? Or do it as a pre-built config that can be downloaded with something like --get_docker_config and then users can change the image version and pass this custom config at will?

@fmalmeida fmalmeida pinned this issue Apr 13, 2023
@fmalmeida fmalmeida unpinned this issue May 19, 2023
@fmalmeida
Copy link
Owner Author

Done in #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant