Skip to content

[BUG] flyte admin crashes with concurrent map read and map write #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
andresgomezfrr opened this issue Nov 20, 2024 · 2 comments · Fixed by #6222
Closed
2 tasks done

[BUG] flyte admin crashes with concurrent map read and map write #6038

andresgomezfrr opened this issue Nov 20, 2024 · 2 comments · Fixed by #6222
Assignees
@pvditt
Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working

Comments

@andresgomezfrr
Copy link
Contributor

andresgomezfrr commented Nov 20, 2024 •
edited
Loading

Describe the bug

Our flyteadmins eventually crash and restart with concurrent map read and map write

error.log

Expected behavior

Avoid the concurrent map read and map write errors

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@andresgomezfrr andresgomezfrr added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Nov 20, 2024
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Nov 21, 2024
@davidmirror-ops davidmirror-ops moved this from Backlog to Assigned in Flyte Issues/PRs maintenance Jan 2, 2025
@pvditt
Copy link
Contributor

pvditt commented Feb 5, 2025

@andresgomezfrr thank you for pointing this out. Will look into this today

@pvditt pvditt mentioned this issue Feb 5, 2025
Merged
3 tasks
@pvditt pvditt added the backlogged For internal use. Reserved for contributor team workflow. label Feb 5, 2025
@github-project-automation github-project-automation bot moved this from Assigned to Done in Flyte Issues/PRs maintenance Feb 6, 2025
@pvditt
Copy link
Contributor

pvditt commented Feb 6, 2025

@andresgomezfrr just merged in a fix for this issue. Unsure when we're getting our next release out - please let me know if you run into further issues after this gets released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvditt pvditt

Labels
backlogged For internal use. Reserved for contributor team workflow. bug Something isn't working
Projects
Flyte Issues/PRs maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

utilize sync maps to map project mappings of prom watches flyteorg/flyte
3 participants
@eapolinario @andresgomezfrr @pvditt