Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devhost: Add VM operation mode (PL-131470) #847

Merged
merged 25 commits into from
Dec 8, 2023
Merged

devhost: Add VM operation mode (PL-131470) #847

merged 25 commits into from
Dec 8, 2023

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Dec 8, 2023

@flyingcircusio/release-managers

Release process

Impact: None, since only activated if the new function is explicitly enabled.

Changelog:

  • devhost: Add new feature to use VMs instead of containers. The new feature is not enabled be default (PL-131470)

Security implications

  • Security requirements defined? (WHERE)
    • No change for existing customer, who use the devhost feature (i.e. default operation mode should be container)
      • Container mode should still work
    • Dev VM SSH should not be accessible from outside (they use an insecure ssh key)
  • Security requirements tested? (EVIDENCE)

leona-ya and others added 25 commits December 8, 2023 11:48
@leona-ya
container: use new mysql settings style for compatability with >=22.05
3551c95
@leona-ya
contianer: Only check visible roles in assertion
f8fa627 
The assertion broke evaluation when trying to evaluate a role
which is deprecated with mkRemovedOptionModule
@leona-ya
devhost: Add VM operation mode
c042ebb 
- Add new image `dev-vm`
- Add new infrastructure mode `dev-vm`
- Add feature switch in devhost role to switch between vms and container (while preserving default)
@ctheune @leona-ya
devhost: apply exception for known secret
651b750
@ctheune @leona-ya
devhost: ensure dev vm management runs as singleton, add locking
2b8203d
@ctheune @leona-ya
devhost: turn management script into python code
8fe1509
@ctheune @leona-ya
devhost: add id and ip management for vms
c55406b
@leona-ya
devhost: customize vm image on first run by mounting it
bedb1e6
@leona-ya
devhost: integrate new dev-vm manage script into NixOS
a344d81
@leona-ya
devhost: add channel switch and fix issues occured in testing
f0f9907
@ctheune @leona-ya
devhost: small bugfixes to management script
4aa09b7
@leona-ya
devhost: remove dnsmasq and fix issue when vm has no aliases
ac403c6
@leona-ya
devhost: fix dnsmasq
4f71414
@leona-ya
devhost: let management script fail in a clean state
c427b66
@leona-ya
devhost: save user and creation date of the vm
c3176ef
@leona-ya
devhost: add vm list command
b1d262d
@leona-ya
devhost: use reflink for vm images
9195e93
@leona-ya
devhost: more efficient locking in management script
4579f51
@leona-ya
devhost: clenaup timer, resolve fixmes
5f58ff1
@leona-ya
services/nginx: allow setting streamConfig
6ad1410
@leona-ya
devhost: delegate acme/https handling to the dev vms
cca9cdc
@leona-ya
devhost: rename management script to fc-devhost
4fd60f6
@leona-ya
devhost: add login command to management script
a94264b
@leona-ya
devhost: code format
3b14fb2
@leona-ya
devhost: don't save ssh host keys
6ce6bbb
@ctheune ctheune merged commit a97b270 into fc-23.11-dev Dec 8, 2023
2 checks passed
@ctheune ctheune deleted the PL-131470-rebuild-devhost-with-vms-23.11 branch December 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctheune ctheune ctheune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leona-ya @ctheune