Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] flyingcircus-physical: make nvme-cli a default package #773

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Aug 25, 2023

We are using nvme disks more and more commonly in our physical infra, not just in storage servers. This requires dedicated tooling for listing and querying information previously available e.g. via smartctl.

@flyingcircusio/release-managers

Release process

Impact: none

Changelog:

  • [internal, physical infra only] add nvme to packages available by default

Security implications

  • Security requirements defined? (WHERE)
    • None, package had already been used in nix-shell when needed; does not automatically start a service
  • Security requirements tested? (EVIDENCE)
    • automated tests still pass

We are using nvme disks more and more commonly in our physical infra,
not just in storage servers. This requires dedicated tooling for listing
and querying information previously available e.g. via smartctl.
@osnyx osnyx requested a review from dpausp August 25, 2023 11:35
@dpausp dpausp merged commit ed7c836 into fc-21.05-dev Aug 25, 2023
1 check passed
@dpausp dpausp deleted the nvme-cli-default branch August 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants